Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draw.io build make target added #205

Merged
merged 14 commits into from
Oct 2, 2023
Merged

draw.io build make target added #205

merged 14 commits into from
Oct 2, 2023

Conversation

pseusys
Copy link
Collaborator

@pseusys pseusys commented Aug 28, 2023 •
edited
Loading

Description

Added make target for building draw.io diagrams with a Docker drawio container.

Checklist

  • I have covered the code with tests
  • I have added comments to my code to help others understand it
  • I have updated the documentation to reflect the changes
  • I have performed a self-review of the changes

@pseusys pseusys marked this pull request as draft August 28, 2023 10:15
@pseusys pseusys requested review from RLKRo and kudep August 30, 2023 06:12
@pseusys pseusys marked this pull request as ready for review September 12, 2023 09:15
@pseusys pseusys self-assigned this Sep 12, 2023
@pseusys pseusys added the documentation Improvements or additions to documentation label Sep 12, 2023
kudep
kudep requested changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@kudep kudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename diagrams to drawio_src or something like that

RLKRo
RLKRo requested changes Sep 13, 2023
View reviewed changes
dff/pipeline/pipeline/actor.py Outdated Show resolved Hide resolved
makefile Outdated Show resolved Hide resolved
docs/source/diagrams/dff/addons.drawio Outdated Show resolved Hide resolved
makefile Outdated Show resolved Hide resolved
RLKRo
RLKRo requested changes Sep 28, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
makefile Outdated Show resolved Hide resolved
@pseusys pseusys requested review from kudep and RLKRo September 29, 2023 09:15
@RLKRo RLKRo merged commit e2f1a13 into dev Oct 2, 2023
16 checks passed
@RLKRo RLKRo deleted the docs/drawio_build_added branch October 2, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RLKRo RLKRo RLKRo approved these changes

@kudep kudep Awaiting requested review from kudep

Assignees

@pseusys pseusys

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pseusys @kudep @RLKRo