fix custom messenger interface #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLKRo
reviewed
Aug 29, 2023
RLKRo
reviewed
Sep 12, 2023
There was a problem hiding this comment.
I think this tutorial needs a rework. It has some issues (e.g. every dialog with this interface shares the same context).
I think it would be best if we remove this tutorial and add CallbackMessengerInterface and a docstring about messenger interfaces in the fastapi tutorial. (also add CallbackMessengerInterface in the websocket_chat tutorial)
# Conflicts: # tutorials/pipeline/6_custom_messenger_interface.py
RLKRo
requested changes
Oct 2, 2023
# Conflicts: # tutorials/messengers/web_api_interface/1_fastapi.py # tutorials/messengers/web_api_interface/2_websocket_chat.py # tutorials/pipeline/6_custom_messenger_interface.py
RLKRo
approved these changes
Nov 14, 2023
RLKRo
added a commit
that referenced
this pull request
Nov 21, 2023
Release v0.6.3 # Release notes - Update README to make it more concise and include reasons to use DFF (#281) - Add [DFF optimization guide](https://deeppavlov.github.io/dialog_flow_framework/user_guides/optimization_guide.html) (#236) - Add documentation section description for the [index page](https://deeppavlov.github.io/dialog_flow_framework/index.html) (#281) - Add async method [dff.messengers.common.interface.CallbackMessengerInterface.on_request_async](https://deeppavlov.github.io/dialog_flow_framework/apiref/dff.messengers.common.interface.html#dff.messengers.common.interface.CallbackMessengerInterface.on_request_async) (#206) - Move information about messenger interfaces from `pipeline.6_custom_messenger_interface` (removed) to [messengers.web_api_interface.1_fastapi](https://deeppavlov.github.io/dialog_flow_framework/tutorials/tutorials.messengers.web_api_interface.1_fastapi.html) (#206) - Fix cross-references in [dff.messengers.common.interface](https://deeppavlov.github.io/dialog_flow_framework/apiref/dff.messengers.common.interface.html) (#206) - Update tutorials to fit into documentation without side-scrolling (#241)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
move custom messenger interface tutor to web_api folder; add form; modify web application logic
Checklist