Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stat tests #272

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Fix stat tests #272

merged 6 commits into from
Nov 9, 2023

Conversation

RLKRo
Copy link
Member

@RLKRo RLKRo commented Nov 8, 2023

Description

This PR fixes issues I found with stats tests while investigating workflow failures:


This PR fixes an issue with randomly failing workflows:

test_get_current_label was using a pipeline from tutorials.stats.1_extractor_functions which had dff_instrumentor = OtelInstrumentor.from_url("grpc://localhost:4317") and unlike other tests it was not reinstrumented with an InMemoryExporter.

test_get_current_label is changed in the following way:

  • A new pipeline is created for that test instead of importing it from a tutorial.
  • Fix the way result is asserted (previously it did not fail when it should have).

This PR updates the way instrumentor is reinstrumented in test_otlp_integration to the same way it is done in test_tutorials (by reinstrumenting an instrumentor from an imported tutorial instead of creating a new one).


This PR replaces example with tutorial in stat tests.


This PR removes unused expected parameter from test_otlp_integration.


Also, while working on this issue I noticed that otel_logs have a null timestamp:
image
However, otel_traces does not have the same issue

Checklist

  • I have covered the code with tests
  • I have added comments to my code to help others understand it
  • I have updated the documentation to reflect the changes
  • I have performed a self-review of the changes

@RLKRo RLKRo added the bug Something isn't working label Nov 8, 2023
@RLKRo RLKRo self-assigned this Nov 8, 2023
@RLKRo RLKRo requested a review from ruthenian8 November 8, 2023 22:51
@RLKRo RLKRo merged commit 62dc6e8 into dev Nov 9, 2023
16 checks passed
@RLKRo RLKRo deleted the fix/test_get_current_label branch November 9, 2023 13:58
@RLKRo RLKRo mentioned this pull request Nov 9, 2023
4 tasks
RLKRo added a commit that referenced this pull request Nov 10, 2023
# Release notes

## dff.stats

- Fix tests for statistics module (#272)
- Dashboard config now persists after restart (#227)
- Fix several bugs with SQL statements for datasets (#227)
- Update guide with information about custom charts (#227)
- Add text descriptions for charts in dashboard (#227)
- Various chart fixes (#227)


## Other

- Update PR template (#258)
- Small doc fixesRelease v0.6.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants