Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issues I found with stats tests while investigating workflow failures:
This PR fixes an issue with randomly failing workflows:
test_get_current_label
was using a pipeline fromtutorials.stats.1_extractor_functions
which haddff_instrumentor = OtelInstrumentor.from_url("grpc://localhost:4317")
and unlike other tests it was notreinstrument
ed with anInMemoryExporter
.test_get_current_label
is changed in the following way:This PR updates the way instrumentor is reinstrumented in
test_otlp_integration
to the same way it is done intest_tutorials
(by reinstrumenting an instrumentor from an imported tutorial instead of creating a new one).This PR replaces
example
withtutorial
in stat tests.This PR removes unused
expected
parameter fromtest_otlp_integration
.Also, while working on this issue I noticed that
otel_logs
have a null timestamp:However, otel_traces does not have the same issue
Checklist