Replace ForwardRef with TYPE_CHECKING #310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When type import would cause cyclic import error, instead of defining types as
ForwardRef
s or pydantic'sBaseModel
s, useTYPE_CHECKING
.This helps tools that work with typing such as
mypy
(this PR reduces the number of errors found withmypy
from 208 to 145).Checklist
To Consider
.ignore
files, scripts (such aslint
), distribution manifest (if files are added/deleted)