Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/positional text #327

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Feat/positional text #327

merged 2 commits into from
Feb 9, 2024

Conversation

Ramimashkouk
Copy link
Member

Description

  • feat: Support Message creation with positional text arg
  • chore: Replace kw-text with positional one in Message instantiations

Checklist

  • I have performed a self-review of the changes

List here tasks to complete in order to mark this PR as ready for review.

To Consider

  • Add tests (if functionality is changed)
  • Update API reference / tutorials / guides
  • Update CONTRIBUTING.md (if devel workflow is changed)
  • Update .ignore files, scripts (such as lint), distribution manifest (if files are added/deleted)
  • Search for references to changed entities in the codebase

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears this PR is a release PR (change its base from master if that is not the case).

Here's a release checklist:

  • Update package version
  • Change PR merge option
  • Test modules without automated testing:
    • Requiring telegram api_id and api_hash
    • Requiring HF_API_KEY
  • Search for objects to be deprecated

@RLKRo RLKRo changed the base branch from master to dev February 7, 2024 16:45
@Ramimashkouk Ramimashkouk requested a review from RLKRo February 7, 2024 16:46
@RLKRo RLKRo merged commit 6d982e0 into dev Feb 9, 2024
2 checks passed
@RLKRo RLKRo deleted the feat/positional_text branch February 9, 2024 12:50
@RLKRo RLKRo mentioned this pull request Mar 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants