-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic improvements #372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to from_script() before, that's not handled right now)
…ced TOY_SCRIPT_ARGS with TOY_SCRIPT_KWARGS
…uted_fields from Pipeline, they're not working as intended
RLKRo
reviewed
Aug 12, 2024
Co-authored-by: Roman Zlobin <RLKRo@proton.me>
This reverts commit 64c8761.
Why call `model_rebuild`?
RLKRo
approved these changes
Aug 19, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
PipelineComponent
,Pipeline
andComponentExtraHandler
are now subclasses of Pydantic'sBaseModel
, massively reducing code bloat in their initialization and that of their children (such asService
).Service
,ServiceGroup
andActor
are now subclasses ofPipelineComponent
. No functionality is removed inServiceGroup
. All tutorials and tests pass like before, with a few changes.Actor
would be called from within aService
with a special flag, which seemed like a workaround, and now it can be called directly as an instance ofPipelineComponent
, instead of heavily relying on theService
class. You could say that this slightly reduces the code's complexity. In fact, it also bindsActor
toPipelineComponent
, instead of it being independent, making code look more cohesive.Service
declaration is removed. (Service
class doesn't acceptService
as it's handler anymore) Same with nestedComponentExtraHandler
s.Service
s would work even if the Service itself was turned off viastart_condition
. That was a bug. Now this condition is checked inPipelineComponent
instead. I assumeActor
must always have it as True.Checklist
from_script()
and other redundant methods.components
intopre-services
andpost-services
throughout tutorials. (atPipeline
initialization)To Consider