Migration to async DB drivers #60

pseusys · 2022-12-27T22:35:22Z

Description

DB drivers changed to their async alternatives

Checklist

I have covered the code with tests
I have added comments to my code to help others understand it
I have updated the documentation to reflect the changes
I have performed a self-review of the changes

github-actions

Please provide a description: what is changed and why.

dff/context_storages/__init__.py

kudep

fix warnings
fix test coverage
do same typing hints in all changed files like in this commit

dff/context_storages/database.py

…ion' into refactor/async_db_drivers_migration # Conflicts: # dff/context_storages/database.py # dff/context_storages/ydb.py

dff/context_storages/database.py

pseusys · 2023-01-15T16:20:11Z

For some reason, YDB test keps getting skipped.

…ion' into refactor/async_db_drivers_migration

pseusys · 2023-02-09T01:29:59Z

The only warning left is related to this bug, here it is said to be fixed until the end of month.

dff/context_storages/database.py

tests/context_storages/test_dbs.py

…libs bug and excluding error handling lines)

.coveragerc

pseusys · 2023-02-13T09:19:10Z

@kudep, 97 - that's a lot. If we add just a few undocumented code lines (and sometimes that's inevitable) - and we'll be struggling to meet this high standard again. Maybe we should give ourselves some space for improvement and leave it at 96 or even 95?

kudep · 2023-02-13T09:27:57Z

So, it's is not true, i mean, we have without excluding 93%, you exclude parts of code and now we have same real coverage with another threshold 97%.
Difference between in terms of lines of code same for 92-93% and 96-97%. It's mean that your question is not relevant If we add just a few undocumented code lines (and sometimes that's inevitable)...

#60 (comment)

kudep · 2023-02-13T09:30:29Z

Also now we can see another issue: local coverage and GH Action's coverage is not match
97 vs 93
do you know about that?

kudep

local and GH Action's covers are not same

pseusys · 2023-02-13T09:57:14Z

Defore you ask about warning, it's a bug in nest_asyncio.

setup.py

Co-authored-by: Roman Zlobin <trlkrot@gmail.com>

pseusys added 2 commits December 27, 2022 17:28

async and sync conflict

e8f8bb7

github docs building reverted

67bd37d

github-actions bot reviewed Dec 27, 2022

View reviewed changes

lint updated

93c04b9

pseusys requested review from kudep and RLKRo December 31, 2022 14:20

pseusys self-assigned this Dec 31, 2022

kudep requested changes Jan 11, 2023

View reviewed changes

dff/context_storages/__init__.py Outdated Show resolved Hide resolved

pseusys and others added 2 commits January 12, 2023 21:08

ydb transferred to sync driver

ab5d288

refactor/async_db_drivers_migration: fix doc

8b31209

kudep requested changes Jan 15, 2023

View reviewed changes

refactor/async_db_drivers_migration: upd type hints in database

cf15f4a

kudep reviewed Jan 15, 2023

View reviewed changes

dff/context_storages/database.py Outdated Show resolved Hide resolved

kudep and others added 5 commits January 15, 2023 15:10

refactor/async_db_drivers_migration: merge

61befdc

context storages method signatures and type hints updated

ef750f3

Merge remote-tracking branch 'origin/refactor/async_db_drivers_migrat…

21457d7

…ion' into refactor/async_db_drivers_migration # Conflicts: # dff/context_storages/database.py # dff/context_storages/ydb.py

validator updated, linted

3003208

test bugs fixed

b4de818

kudep requested changes Jan 15, 2023

View reviewed changes

dff/context_storages/database.py Outdated Show resolved Hide resolved

pseusys added 10 commits January 15, 2023 20:30

postgres deprecation warning fix

3952e58

DBAbstractContextStorage merged with DBContextStorage

86cdd83

tests passing

04f0baa

docs building fixed

b87bb57

deleted obsolete, skipped tests info added

17a3fc6

pytest full added skipped info

1b3757d

Merge branch 'dev' into refactor/async_db_drivers_migration

0a90d92

attempt to fix ydb skipping

5957b97

Merge remote-tracking branch 'origin/refactor/async_db_drivers_migrat…

49ddef0

…ion' into refactor/async_db_drivers_migration

venv blocking returned

2351209

RLKRo approved these changes Feb 10, 2023

View reviewed changes

dff/context_storages/database.py Outdated Show resolved Hide resolved

tests/context_storages/test_dbs.py Outdated Show resolved Hide resolved

pseusys added 4 commits February 10, 2023 21:54

__init__.py's reformatted + coverage raised (by fixing concurrency …

0026244

…libs bug and excluding error handling lines)

casts removed

9564254

indentation issue fixed

f2ead44

database fields docs moved to __init__()

ff9db29

pseusys requested review from kudep and RLKRo February 10, 2023 21:00

RLKRo requested changes Feb 10, 2023

View reviewed changes

.coveragerc Show resolved Hide resolved

pseusys and others added 5 commits February 10, 2023 22:29

pragma reversed

90144c3

attempt to fix windows 8 stacking issue

142e008

attempt to fix windows python8 stacking issue

9b4628d

attempt to fix windows python8 hanging issue (correct now)

f4bd682

refactor/async_db_drivers_migration: upd cover threshhold

46634e5

kudep approved these changes Feb 13, 2023

View reviewed changes

kudep requested changes Feb 13, 2023

View reviewed changes

pseusys added 2 commits February 13, 2023 10:50

pytest plugins versions updated

0e42724

.coveragerc added to special excluded files list

8fa79be

kudep approved these changes Feb 13, 2023

View reviewed changes

RLKRo reviewed Feb 13, 2023

View reviewed changes

setup.py Outdated Show resolved Hide resolved

dependency and workflow changes reverted

2914a10

RLKRo reviewed Feb 13, 2023

View reviewed changes

setup.py Outdated Show resolved Hide resolved

Update setup.py

4af1868

Co-authored-by: Roman Zlobin <trlkrot@gmail.com>

RLKRo approved these changes Feb 13, 2023

View reviewed changes

kudep merged commit 2c23486 into dev Feb 13, 2023

kudep deleted the refactor/async_db_drivers_migration branch February 13, 2023 18:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migration to async DB drivers #60

Migration to async DB drivers #60

pseusys commented Dec 27, 2022 •

edited

Loading

github-actions bot left a comment

kudep left a comment •

edited by pseusys

Loading

pseusys commented Jan 15, 2023

pseusys commented Feb 9, 2023

pseusys commented Feb 13, 2023

kudep commented Feb 13, 2023

kudep commented Feb 13, 2023 •

edited

Loading

kudep left a comment

pseusys commented Feb 13, 2023

Migration to async DB drivers #60

Migration to async DB drivers #60

Conversation

pseusys commented Dec 27, 2022 • edited Loading

Description

Checklist

github-actions bot left a comment

Choose a reason for hiding this comment

kudep left a comment • edited by pseusys Loading

Choose a reason for hiding this comment

pseusys commented Jan 15, 2023

pseusys commented Feb 9, 2023

pseusys commented Feb 13, 2023

kudep commented Feb 13, 2023

kudep commented Feb 13, 2023 • edited Loading

kudep left a comment

Choose a reason for hiding this comment

pseusys commented Feb 13, 2023

pseusys commented Dec 27, 2022 •

edited

Loading

kudep left a comment •

edited by pseusys

Loading

kudep commented Feb 13, 2023 •

edited

Loading