Fix cards #119
Open
Fix cards #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trubachev
reviewed
Jul 3, 2018
| </h5> | ||
| </div> | ||
| <div class="card speaker-card card-margin"> | ||
| <a href={{speaker.url}}><img class="card-img-top" src="{{speaker.avatar}}" alt="{{speaker.title}}"/></a> |
There was a problem hiding this comment.
можно всю карточку обернуть в <a>
There was a problem hiding this comment.
Так слетает автоматическое выравнивание по высоте в карточке.
|
Карточки спикеров хорошо получились, но во встречах теперь тяжело отследить их порядок. Они идут в три колонки каждая снизу вверх по возрастанию - не очень удобно. Может там также зафорсить размер изображения и привести все встречи к одному виду? |
|
@aikikode я бы вообще их списком сделал. |
|
@achikin давай зафорсим единый размер для всех картинок встреч - так эта страничка будет выглядеть так же ровно, как и страница спикеров. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.