-
Notifications
You must be signed in to change notification settings - Fork 94
add agents example with GitHub components & tools from new integration #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -0,0 +1,930 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a description before this, explaning what we're doing. Somethinglike:
GitHub Issue Resolver
First, we'll create a GitHub issue resolver agent, following the steps in this recipe: Build a GitHub Issue Resolver Agent(https://haystack.deepset.ai/cookbook/github_issue_resolver_agent)
Reply via ReviewNB
@@ -0,0 +1,930 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the website, this markdown output is rendered as part of the recipe. We need to either copy and put it as a text or remove it completely
Reply via ReviewNB
@@ -0,0 +1,930 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,930 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left my comments on review nb
This new notebook goes beyond what the GitHub Issue Resolver notebook shows. It additionally forks the repository, edits files in multiple commits and simulates opening a pull request. Here is an example:
deepset-ai/haystack-core-integrations@main...haystack-demo-user:haystack-core-integrations:fix-1268
When users run the tutorial, they will actually fork the repo and in their fork they will actually create some commits, which is nice. They won't automatically open an actual PR, which is nice too. :D
For context: @sjrl brought up that one way to keep example files from the experimental Agent around is an integration deepset-ai/haystack-experimental#263 (comment)
deepset-ai/haystack-core-integrations#1637