Skip to content

add agents example with GitHub components & tools from new integration #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

julian-risch
Copy link
Member

@julian-risch julian-risch commented Apr 10, 2025

This new notebook goes beyond what the GitHub Issue Resolver notebook shows. It additionally forks the repository, edits files in multiple commits and simulates opening a pull request. Here is an example:
deepset-ai/haystack-core-integrations@main...haystack-demo-user:haystack-core-integrations:fix-1268

When users run the tutorial, they will actually fork the repo and in their fork they will actually create some commits, which is nice. They won't automatically open an actual PR, which is nice too. :D

For context: @sjrl brought up that one way to keep example files from the experimental Agent around is an integration deepset-ai/haystack-experimental#263 (comment)

deepset-ai/haystack-core-integrations#1637

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@julian-risch julian-risch marked this pull request as ready for review June 12, 2025 15:16
@julian-risch julian-risch changed the title add agents example with GitHub components from experimental add agents example with GitHub components & tools from new integration Jun 12, 2025
@@ -0,0 +1,930 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a description before this, explaning what we're doing. Somethinglike:

GitHub Issue Resolver

First, we'll create a GitHub issue resolver agent, following the steps in this recipe: Build a GitHub Issue Resolver Agent(https://haystack.deepset.ai/cookbook/github_issue_resolver_agent)


Reply via ReviewNB

@@ -0,0 +1,930 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the website, this markdown output is rendered as part of the recipe. We need to either copy and put it as a text or remove it completely


Reply via ReviewNB

@@ -0,0 +1,930 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do I pass a title here?


Reply via ReviewNB

@@ -0,0 +1,930 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here with the markdown content


Reply via ReviewNB

Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my comments on review nb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Agent from experimental to main
2 participants