-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] feat: add multimodal support for ChatMessage #145
base: main
Are you sure you want to change the base?
Conversation
3073aae
to
6031934
Compare
@LastRemote first of all thanks for this effort - kudos. I see how you figured out the same directionI would chose for this endeavour. We need a new dataclass Let us get back to you when @anakin87 comes from PTO so we can coordinate this effort. I think we need to break down this PR into several PRs and integration steps:
Thoughts @mpangrazzi ? |
Thanks, glad that it aligns with what your had in mind. Let's hear back from them first and we can break this down into smaller PRs afterwards. |
@LastRemote Hi! Discussed with @vblagoje and I agree with him, PR is surely valid but a bit too convoluted. Breaking it down as he suggested would probably be the best for us! |
@vblagoje @mpangrazzi Thanks for the feedback, I will try to break this down into smaller PRs. Shall we close this one and use #135 as the megathread to check all the PRs? |
Btw here's the first one: #157 |
Related Issues
Proposed Changes:
Added multimodal support according to deepset-ai/haystack#7848 (comment)
Adjusted openai/anthropic utils to allow converting media contents to their API format (I personally use httpx to send and parse the response. Please let me know if OpenAI/Anthropic SDK expects a different format).
How did you test it?
Added unit tests, and E2E tests with customized httpx-based AzureOpenAI/BedrockAnthropic generators.
Notes for the reviewer
_name
field back since it is useful in some multi-agent setups. Also finally I have a default value for it so no more headaches when serializing/deserializing this.ChatMessage
? Personally I find it very annoying.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.