fix: OpenAPITool - use keyword args for chat generator run invocation
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vblagoje
requested review from
silvanocerza and
shadeMe
and removed request for
a team and
silvanocerza
vblagoje
changed the title
OpenAPITool - use keyword args for chat generator run invocation
|
Madeesh - this fix is blocking @davidsbatista and others from moving forward. |
Pull Request Test Coverage Report for Build 10450623704Details
💛 - Coveralls |
anakin87
approved these changes
Aug 19, 2024
shadeMe
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the main haystack project pull request 8054 added a new parameter in chat generator run methods.
Since we didn't use keyword arguments in invocation of the run method of the chat generator in
openapi_tool.pywe need to now use keyword arguments.