Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Opensearch field type (flattened -> nested) #1609

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Fix Opensearch field type (flattened -> nested) #1609

merged 2 commits into from
Oct 19, 2021

Conversation

tholor
Copy link
Member

@tholor tholor commented Oct 19, 2021 •
edited
Loading

Proposed changes:

  • Opensearch doesn't support (natively) the field type "flattened". There are options to use third party plugins but at this point it seems more pragmatic to switch to a "nested" field type here in the label index
  • Also switching the default port from 9201 to 9200 as this is what you mostly find as a port in the opensearch docs (e.g. get started)

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

Fixes #1607

@tholor tholor requested a review from ZanSara October 19, 2021 12:28
ZanSara
ZanSara approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@tholor tholor merged commit 3a7d029 into master Oct 19, 2021
@tholor tholor deleted the fix_opensearch_flattened branch October 19, 2021 12:40
@anakin87 anakin87 mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

Assignees
No one assigned
Labels
topic:document_store
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenSearchDocumentStore: No handler for type [flattened] declared on field [answer]
2 participants
@tholor @ZanSara