Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make Azure integration tests more robust #5906

Merged
merged 1 commit into from
Sep 28, 2023
Merged

test: make Azure integration tests more robust #5906

merged 1 commit into from
Sep 28, 2023

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

  • More robust skipif conditions in Azure integration tests

How did you test it?

Local run

Notes for the reviewer

I am not sure if this solves the failures in #5736, but in any case, it seems like an improvement.

Checklist

@anakin87 anakin87 added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 28, 2023
@anakin87 anakin87 requested a review from a team as a code owner September 28, 2023 09:40
@anakin87 anakin87 requested review from masci and removed request for a team September 28, 2023 09:40
ZanSara
ZanSara approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6337193215

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on better-azure-tests at 49.927%
Totals Coverage Status
Change from base Build 6332291126: 49.9%
Covered Lines: 12347
Relevant Lines: 24730
💛 - Coveralls

@anakin87 anakin87 merged commit 9340c57 into main Sep 28, 2023
53 checks passed
@anakin87 anakin87 deleted the better-azure-tests branch September 28, 2023 10:09
@anakin87 anakin87 mentioned this pull request Sep 28, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

@masci masci Awaiting requested review from masci masci is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anakin87 @coveralls @ZanSara