refactor: Add support for new filters declaration #6397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
This PR changes
MetadataRouter
andInMemoryDocumentStore
to support new filters as defined in proposal #6001.I also updated the
DocumentStore
protocol docstring to reflect the support of new filters.How did you test it?
I added new tests and update the ones failing cause of the behaviour change.
Notes for the reviewer
InMemoryDocumentStore
still uses legacy filters converted to new ones in tests as I'll add tests for new filters intesting/document_store.py
in a later PR.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.