-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement apply_filter_policy and FilterPolicy.MERGE for the new filters #8042
Conversation
Pull Request Test Coverage Report for Build 10305030806Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
370c595
to
f04c805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also some logic that doesn't have enough test coverage (c.f coveralls report). Let's fix that as well.
releasenotes/notes/document-splitter-accept-split-threshold-467abb9fcd1c316b.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/implement-merge-filter-logic-99e6785a78f80ae9.yaml
Outdated
Show resolved
Hide resolved
This should be it now, see commits since c8a53f2 onward |
releasenotes/notes/document-splitter-accept-split-threshold-467abb9fcd1c316b.yaml
Outdated
Show resolved
Hide resolved
Offline we agreed to eviscerate LogicalOperator enum and use Literal strings for operators. The change is in a1cc6f9 |
Why:
Implements proper merging of new filters.
apply_filter_policy
andFilterPolicy.MERGE
don't work properly for the new filter syntax #7995What:
is_legacy
,is_comparison_filter
,is_logical_filter
).apply_filter: policy
function to support merging ofinit_filters
withruntime_filters
using a logical operator, facilitating complex filter scenarios.How can it be used:
The enhancements enable complex filter logic to be applied seamlessly in document query operations, such as:
AND
,OR
) when merging comparison or logical filters, allowing for a more nuanced filter logic that can accurately reflect user needs or query specifics.Example usage of merging comparison and logical filters:
How did you test it:
A series of unit tests were added covering various scenarios including:
MERGE
andREPLACE
policies with different combinations of comparison and logical filters.Notes for the reviewer:
apply_filter_policy
to ensure all potential scenarios are covered and the expected behavior is clearly documented and verified.