Skip to content

build: unpin structlog #8071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2024
Merged

build: unpin structlog #8071

merged 1 commit into from
Jul 24, 2024

Conversation

@wochinge
Copy link
Contributor

@wochinge wochinge commented Jul 24, 2024 •
edited by vblagoje
Loading

Related Issues

Proposed Changes:

  • unpin structlog
  • adapted the tests so that they pass (nothing critical was changed, seems structlog is now only omitted empty values correctly)

How did you test it?

Notes for the reviewer

Checklist

@wochinge wochinge requested a review from a team as a code owner July 24, 2024 17:03
@wochinge wochinge requested review from vblagoje and removed request for a team July 24, 2024 17:03
@wochinge wochinge added ignore-for-release-notes PRs with this flag won't be included in the release notes. and removed topic:tests topic:build/distribution labels Jul 24, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jul 24, 2024

Pull Request Test Coverage Report for Build 10080912165

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.143%
Totals Coverage Status
Change from base Build 10077931986: 0.0%
Covered Lines: 6859
Relevant Lines: 7609
💛 - Coveralls

vblagoje
vblagoje approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice 🚀

@vblagoje vblagoje merged commit 4dde6fb into main Jul 24, 2024
@vblagoje vblagoje deleted the build/unpin-structlog branch July 24, 2024 18:58
@vblagoje vblagoje mentioned this pull request Jul 24, 2024
Closed
silvanocerza pushed a commit that referenced this pull request Jul 26, 2024
@wochinge @silvanocerza
build: unpin structlog (#8071)
cb1cecf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees

No one assigned

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: Unpin structlog and fix breaking tests

4 participants

@wochinge @coveralls @vblagoje