Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Deprecate the debug parameter in Pipeline.run #8075

Merged
merged 1 commit into from
Jul 25, 2024
Merged

chore: Deprecate the debug parameter in Pipeline.run #8075

merged 1 commit into from
Jul 25, 2024

Conversation

shadeMe
Copy link
Collaborator

@shadeMe shadeMe commented Jul 25, 2024

Related Issues

Proposed Changes:

It's a vestigial/unused parameter in 2.x.

Checklist

@shadeMe shadeMe requested a review from a team as a code owner July 25, 2024 09:27
@shadeMe shadeMe requested review from silvanocerza and removed request for a team July 25, 2024 09:27
@shadeMe shadeMe force-pushed the chore/remove-deprecated-param-pipeline-run branch from cd10b0d to e8031e3 Compare July 25, 2024 09:30
@shadeMe shadeMe requested a review from a team as a code owner July 25, 2024 09:30
@shadeMe shadeMe requested review from dfokina and removed request for a team July 25, 2024 09:30
@shadeMe shadeMe enabled auto-merge (squash) July 25, 2024 09:30
@coveralls
Copy link
Collaborator

coveralls commented Jul 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10091676771

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 90.145%
Files with Coverage Reduction New Missed Lines %
core/pipeline/pipeline.py 13 79.78%
Totals Coverage Status
Change from base Build 10082446389: 0.002%
Covered Lines: 6860
Relevant Lines: 7610
💛 - Coveralls

@shadeMe shadeMe merged commit f9e4d5d into main Jul 25, 2024
18 checks passed
@shadeMe shadeMe deleted the chore/remove-deprecated-param-pipeline-run branch July 25, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate debug parameter in Pipeline.run
3 participants
@shadeMe @coveralls @silvanocerza