Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate to_openai_format and create similar utility functions #8146

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Aug 1, 2024

Related Issues

Proposed Changes:

  • deprecate to_openai_format
  • create _convert_message_to_openai_format in components/generators/openai_utils.py
  • create _convert_message_to_hfapic_format in components/generators/chat/hugging_face_api.py

How did you test it?

CI, new tests

Notes for the reviewer

I'm introducing some duplication, but it might make sense, considering how different formats can evolve.

Checklist

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Aug 1, 2024
@coveralls
Copy link
Collaborator

coveralls commented Aug 1, 2024

Pull Request Test Coverage Report for Build 10200746237

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.111%

Files with Coverage Reduction New Missed Lines %
components/generators/chat/hugging_face_api.py 2 97.75%
components/generators/openai.py 3 96.43%
components/generators/chat/openai.py 9 79.28%
Totals Coverage Status
Change from base Build 10200239554: 0.02%
Covered Lines: 6880
Relevant Lines: 7635

💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review August 1, 2024 14:59
@anakin87 anakin87 requested review from a team as code owners August 1, 2024 14:59
@anakin87 anakin87 requested review from dfokina, julian-risch and silvanocerza and removed request for a team and julian-risch August 1, 2024 14:59
@anakin87 anakin87 merged commit e17d0c4 into main Aug 2, 2024
31 checks passed
@anakin87 anakin87 deleted the deprecate-to-oai-format branch August 2, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants