Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused functions serialize_callback_handler and deserialize_callback_handler #8172

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Aug 8, 2024

Related Issues

These utility functions are probably a leftover.

I checked that they are not used anywhere: haystack, core-integrations, integrations page, website, tutorials, cookbook...

Some related issues (in case you are interested in history 😃): #6979 #6988 deepset-ai/haystack-core-integrations#415

Proposed Changes:

Remove these functions

How did you test it?

CI

Checklist

@github-actions github-actions bot added the type:documentation Improvements on the docs label Aug 8, 2024
@anakin87 anakin87 marked this pull request as ready for review August 8, 2024 08:45
@anakin87 anakin87 requested review from a team as code owners August 8, 2024 08:45
@anakin87 anakin87 requested review from dfokina and davidsbatista and removed request for a team August 8, 2024 08:45
@coveralls
Copy link
Collaborator

coveralls commented Aug 8, 2024

Pull Request Test Coverage Report for Build 10298900492

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 90.167%

Files with Coverage Reduction New Missed Lines %
components/generators/utils.py 1 66.67%
Totals Coverage Status
Change from base Build 10284638870: 0.02%
Covered Lines: 6914
Relevant Lines: 7668

💛 - Coveralls

Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - also did a double check and seems are not being used anywhere

@anakin87 anakin87 merged commit a4eb88e into main Aug 8, 2024
31 checks passed
@anakin87 anakin87 deleted the rm-serde-callback-handler branch August 8, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants