Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up docstrings: AzureOpenAIDocumentEmbedder & AzureOpenAITextEmbedder #8182

Merged
merged 4 commits into from
Aug 13, 2024
Merged

clean up docstrings: AzureOpenAIDocumentEmbedder & AzureOpenAITextEmbedder #8182

merged 4 commits into from
Aug 13, 2024

Conversation

dfokina
Copy link
Contributor

@dfokina dfokina commented Aug 9, 2024

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@dfokina dfokina added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Aug 9, 2024
@dfokina dfokina requested a review from a team as a code owner August 9, 2024 12:24
@dfokina dfokina requested review from julian-risch and removed request for a team and julian-risch August 9, 2024 12:24
@github-actions github-actions bot added the type:documentation Improvements on the docs label Aug 9, 2024
@coveralls
Copy link
Collaborator

coveralls commented Aug 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10369244531

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 36 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 90.122%
Files with Coverage Reduction New Missed Lines %
components/embedders/azure_text_embedder.py 12 66.67%
components/embedders/azure_document_embedder.py 24 53.62%
Totals Coverage Status
Change from base Build 10369156873: 0.0%
Covered Lines: 6961
Relevant Lines: 7724
💛 - Coveralls

dfokina and others added 2 commits August 13, 2024 13:56
@dfokina @agnieszka-m
Apply suggestions from code review
a845fd0 
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
@dfokina
Merge branch 'main' into azureembed_docstrings
657c536
@dfokina dfokina enabled auto-merge (squash) August 13, 2024 11:56
@dfokina dfokina merged commit 1284ca2 into main Aug 13, 2024
14 checks passed
@dfokina dfokina deleted the azureembed_docstrings branch August 13, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnieszka-m agnieszka-m agnieszka-m approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean up docstrings: AzureOpenAIDocumentEmbedder & AzureOpenAITextEmbedder
3 participants
@dfokina @coveralls @agnieszka-m