Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add sede_with_list_output_type_in_pipeline unit test #8196

Merged
merged 2 commits into from
Aug 13, 2024
Merged

chore: Add sede_with_list_output_type_in_pipeline unit test #8196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cda310
Add sede_with_list_output_type_in_pipeline unit test
vblagoje Aug 12, 2024
60b4b3f
Merge branch 'main' into output_adapter_sede
vblagoje Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions test/components/converters/test_output_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# SPDX-FileCopyrightText: 2022-present deepset GmbH <info@deepset.ai>
#
# SPDX-License-Identifier: Apache-2.0

from typing import List
import json

import pytest
Expand Down Expand Up @@ -129,6 +131,17 @@ def test_sede_with_multiple_custom_filters(self):
# invoke the custom filter to check if it is deserialized correctly
assert deserialized_adapter.custom_filters["custom_filter"]("test") == "TEST"

def test_sede_with_list_output_type_in_pipeline(self):
pipe = Pipeline()
pipe.add_component("adapter", OutputAdapter(template="{{ test }}", output_type=List[str]))
serialized_pipe = pipe.dumps()

# we serialize the pipeline and check if the output type is serialized correctly (as typing.List[str])
assert "typing.List[str]" in serialized_pipe

deserialized_pipe = Pipeline.loads(serialized_pipe)
assert deserialized_pipe.get_component("adapter").output_type == List[str]

def test_output_adapter_from_dict_custom_filters_none(self):
component = OutputAdapter.from_dict(
data={
Expand Down
Loading