Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up docstrings: ChatPromptBuilder #8210

Merged
merged 3 commits into from
Aug 14, 2024
Merged

clean up docstrings: ChatPromptBuilder #8210

merged 3 commits into from
Aug 14, 2024

Conversation

dfokina
Copy link
Contributor

@dfokina dfokina commented Aug 13, 2024

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@dfokina dfokina added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Aug 13, 2024
@dfokina dfokina requested a review from a team as a code owner August 13, 2024 11:45
@dfokina dfokina requested review from silvanocerza and removed request for a team and silvanocerza August 13, 2024 11:45
@github-actions github-actions bot added the type:documentation Improvements on the docs label Aug 13, 2024
@coveralls
Copy link
Collaborator

coveralls commented Aug 13, 2024

Pull Request Test Coverage Report for Build 10369358407

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 90.122%

Files with Coverage Reduction New Missed Lines %
components/builders/chat_prompt_builder.py 1 98.46%
Totals Coverage Status
Change from base Build 10369331519: 0.0%
Covered Lines: 6961
Relevant Lines: 7724

💛 - Coveralls

haystack/components/builders/chat_prompt_builder.py Outdated Show resolved Hide resolved
haystack/components/builders/chat_prompt_builder.py Outdated Show resolved Hide resolved
haystack/components/builders/chat_prompt_builder.py Outdated Show resolved Hide resolved
haystack/components/builders/chat_prompt_builder.py Outdated Show resolved Hide resolved
haystack/components/builders/chat_prompt_builder.py Outdated Show resolved Hide resolved
haystack/components/builders/chat_prompt_builder.py Outdated Show resolved Hide resolved
dfokina and others added 2 commits August 13, 2024 14:04
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
@dfokina dfokina enabled auto-merge (squash) August 13, 2024 12:04
@dfokina dfokina merged commit 5ac56eb into main Aug 14, 2024
14 checks passed
@dfokina dfokina deleted the chatprompt_docstrings branch August 14, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean up docstrings: ChatPromptBuilder
3 participants