clean up docstrings: DocumentLanguageClassifier #8215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfokina
added
the
ignore-for-release-notes
dfokina
requested review from
anakin87
and removed request for
a team and
anakin87
Pull Request Test Coverage Report for Build 10388576420Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
agnieszka-m
requested changes
Aug 14, 2024
haystack/components/classifiers/document_language_classifier.py
Outdated
Show resolved
Hide resolved
haystack/components/classifiers/document_language_classifier.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
agnieszka-m
approved these changes
Aug 16, 2024
srini047
pushed a commit
to srini047/haystack
that referenced
this pull request
Sep 4, 2024
* doclangclass-strings * simplify sentence * simplify sentence 2 * Apply suggestions from code review Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com> --------- Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.