Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up docstrings: WhisperTranscribers #8235

Merged
merged 4 commits into from
Aug 16, 2024
Merged

clean up docstrings: WhisperTranscribers #8235

merged 4 commits into from
Aug 16, 2024

Conversation

dfokina
Copy link
Contributor

@dfokina dfokina commented Aug 15, 2024

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@dfokina dfokina added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Aug 15, 2024
@dfokina dfokina requested a review from a team as a code owner August 15, 2024 12:45
@dfokina dfokina requested review from anakin87 and removed request for a team and anakin87 August 15, 2024 12:45
@github-actions github-actions bot added the type:documentation Improvements on the docs label Aug 15, 2024
@coveralls
Copy link
Collaborator

coveralls commented Aug 15, 2024

Pull Request Test Coverage Report for Build 10419001659

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 90.125%

Files with Coverage Reduction New Missed Lines %
components/audio/whisper_local.py 5 92.19%
components/audio/whisper_remote.py 6 69.05%
Totals Coverage Status
Change from base Build 10418721203: 0.0%
Covered Lines: 6936
Relevant Lines: 7696

💛 - Coveralls

haystack/components/audio/whisper_local.py Outdated Show resolved Hide resolved
haystack/components/audio/whisper_remote.py Outdated Show resolved Hide resolved
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
@dfokina dfokina enabled auto-merge (squash) August 16, 2024 10:59
@dfokina dfokina merged commit 35b1215 into main Aug 16, 2024
14 checks passed
@dfokina dfokina deleted the whisper-docstrings branch August 16, 2024 11:28
srini047 pushed a commit to srini047/haystack that referenced this pull request Sep 4, 2024
* clarify docstrings

* Apply suggestions from code review

Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>

---------

Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean up docstrings: WhisperTranscribers
3 participants