fix: make meta produced by DOCXToDocument JSON serializable
#8263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
requested review from
dfokina and
Amnah199
and removed request for
a team
Pull Request Test Coverage Report for Build 10507658991Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Amnah199
reviewed
Aug 22, 2024
| @@ -47,13 +46,13 @@ class DOCXMetadata: | |||
| category: str | |||
| comments: str | |||
| content_status: str | |||
| created: Optional[datetime] | |||
| created: Optional[str] | |||
There was a problem hiding this comment.
Just curious, why is it marked as optional?
There was a problem hiding this comment.
Date properties return None if not set.
from https://python-docx.readthedocs.io/en/latest/api/document.html#coreproperties-objects
Amnah199
approved these changes
Aug 22, 2024
shadeMe
approved these changes
Aug 22, 2024
srini047
pushed a commit
to srini047/haystack
that referenced
this pull request
Sep 4, 2024
…t-ai#8263) * make meta from DOCXToDocument JSON serializable * unused import * update docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Simply convert the
datetimeobject to stringsHow did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.