Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make arrow an optional dependency #8345

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

silvanocerza
Copy link
Contributor

Related Issues

Relates to #8233

Proposed Changes:

Make the recently introduced arrow dependency an lazily imported one.

How did you test it?

I added unit tests and ran them locally.

Notes for the reviewer

I won't add a release notes as this doesn't changes anything that has been released already.

Checklist

@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 9, 2024
@silvanocerza silvanocerza self-assigned this Sep 9, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner September 9, 2024 13:12
@silvanocerza silvanocerza requested review from davidsbatista, shadeMe, a team and vblagoje and removed request for a team September 9, 2024 13:12
@coveralls
Copy link
Collaborator

coveralls commented Sep 9, 2024

Pull Request Test Coverage Report for Build 10774379191

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 90.309%

Totals Coverage Status
Change from base Build 10773939667: 0.007%
Covered Lines: 7092
Relevant Lines: 7853

💛 - Coveralls

@silvanocerza silvanocerza merged commit da49e78 into main Sep 9, 2024
18 checks passed
@silvanocerza silvanocerza deleted the handle-arrow-dependency branch September 9, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants