Skip to content

Conversation

@sjrl
Copy link
Contributor

@sjrl sjrl commented Apr 22, 2025

Related Issues

  • fixes #issue-number

Proposed Changes:

Updates from_dict to handle splitting_function: None

How did you test it?

Updated from_dict test for this behavior

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@sjrl sjrl requested a review from a team as a code owner April 22, 2025 06:45
@sjrl sjrl requested review from vblagoje and removed request for a team April 22, 2025 06:45
@sjrl sjrl requested a review from julian-risch April 22, 2025 06:46
@sjrl sjrl added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Apr 22, 2025
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@julian-risch julian-risch removed the request for review from vblagoje April 22, 2025 06:47
@sjrl sjrl enabled auto-merge (squash) April 22, 2025 06:49
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14588482131

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.479%

Files with Coverage Reduction New Missed Lines %
components/preprocessors/document_preprocessor.py 1 95.56%
core/pipeline/async_pipeline.py 3 67.32%
Totals Coverage Status
Change from base Build 14532049680: -0.02%
Covered Lines: 10814
Relevant Lines: 11952

💛 - Coveralls

@sjrl sjrl self-assigned this Apr 22, 2025
@sjrl sjrl merged commit 0f374e0 into main Apr 22, 2025
16 of 17 checks passed
@sjrl sjrl deleted the fix-doc-preprocessor-sede branch April 22, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants