feat: Add serialization and deserialization of Enum type when creating a PipelineSnaphsot
#9869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
type:documentation
sjrl
commented
Oct 13, 2025
Comment on lines
-156
to
-158
| def _convert_to_basic_types(value: Any) -> Any: | ||
| """ | ||
| Helper function to recursively convert complex Python objects into their basic type equivalents. |
Contributor
Author
There was a problem hiding this comment.
By handling every base case in _serialize_value_with_schema we no longer need this helper function.
sjrl
commented
Oct 13, 2025
Comment on lines
402
to
406
| # def test_serialize_and_deserialize_value_with_enum(): | ||
| # data = CustomEnum.ONE | ||
| # expected = {"serialization_schema": {"type": "test_base_serialization.CustomEnum"}, "serialized_data": "ONE"} | ||
| # assert _serialize_value_with_schema(data) == expected | ||
| # assert _deserialize_value_with_schema(expected) == data |
Contributor
Author
There was a problem hiding this comment.
This test is currently failing b/c it triggers the elif hasattr(payload, "__dict__"): check and since an Enum object refers to itself within it's __dict__ attributes we get a recursion error.
Collaborator
Pull Request Test Coverage Report for Build 18493209102Details
💛 - Coveralls |
sjrl
changed the title
sjrl
commented
Oct 14, 2025
sjrl
commented
Oct 14, 2025
sjrl
changed the title
PipelineSnaphsot
Amnah199
reviewed
Oct 14, 2025
Amnah199
reviewed
Oct 14, 2025
Amnah199
reviewed
Oct 14, 2025
| if schema.get("uniqueItems") is True: | ||
| final_array = set(deserialized_items) | ||
| # Is a tuple if minItems and maxItems are set and equal | ||
| elif schema.get("minItems") is not None and schema.get("maxItems") is not None: |
Contributor
There was a problem hiding this comment.
Do we need to explicitly check if minItems and maxItems are equal?
Contributor
Author
There was a problem hiding this comment.
I think checking for them now is enough. This was our check from before, I'll update the comment
Amnah199
reviewed
Oct 14, 2025
Amnah199
approved these changes
Oct 14, 2025
Contributor
Amnah199
left a comment
Amnah199
left a comment
There was a problem hiding this comment.
Thanks for the updates!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
_serialize_value_with_schemaand_deserialize_value_with_schematest_base_serialization.pyto reduce duplicate code and to test more scenariosHow did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.