Skip to content

Update build process on invoking setup.py #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Update build process on invoking setup.py #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cdb1a7
Update build process on invoking setup.py
loadams Feb 25, 2025
6e7161f
Merge branch 'main' into loadams/update-setup-py-build
loadams Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ jobs:
python release/check_release_version.py --release_version ${{ env.RELEASE_VERSION }}
- name: Build DeepSpeed-MII
run: |
MII_BUILD_STRING=" " python setup.py bdist_wheel
pip install build
MII_BUILD_STRING=" " python -m build --wheel
- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
Expand Down
2 changes: 1 addition & 1 deletion release/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ if [ $? != 0 ]; then
exit 1
fi

MII_BUILD_STRING="" python setup.py bdist_wheel
MII_BUILD_STRING="" python -m build --wheel
WHL=deepspeed_mii-${version}-py3-none-any.whl

if [ ! -f dist/${WHL} ]; then
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def command_exists(cmd):
version_str = open('version.txt', 'r').read().strip()

# Build specifiers like .devX can be added at install time. Otherwise, add the git hash.
# example: MII_BUILD_STR=".dev20201022" python setup.py sdist bdist_wheel
# example: MII_BUILD_STR=".dev20201022" python -m build --sdist --wheel

MII_BUILD_STRING = 'MII_BUILD_STRING'
BUILD_FILE = 'build.txt'
Expand Down