Add Windows support in README, use c++17 on Windows to support latest VC & cuda build tool#1151
Merged
eltonzheng merged 4 commits intomasterfrom Jun 10, 2021
Merged
Conversation
eltonzheng
requested review from
ShadenSmith,
arashashari,
awan-10,
cli99,
conglongli,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
jeffra
approved these changes
Jun 9, 2021
README.md
Outdated
|
|
||
| On Windows you can build wheel with following steps, currently only inference mode is supported. | ||
| 1. Install pytorch, such as pytorch 1.8 + cuda 11.1 | ||
| 2. Install latest visual cpp build tool |
Collaborator
There was a problem hiding this comment.
Is there a version that we've used for this? "latest" will probably change over time so it might be nice to tell folks which version we know works.
Contributor
Author
There was a problem hiding this comment.
cool, will add detailed version info here.
RezaYazdaniAminabadi
approved these changes
Jun 9, 2021
…peed into eltonz/windows_in_readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.