Skip to content

undo noise #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShadenSmith merged 2 commits into from
Jun 26, 2021
Merged

undo noise #1191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b37c79
undo noise
stas00 Jun 26, 2021
cfb786c
another
stas00 Jun 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepspeed/runtime/zero/stage3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
from deepspeed.utils.debug import debug_module2name_id, debug_param2name_id_numel, debug_param2name_id_shape_device, debug_module2name_class, printflock, log_rank_file


def print_rank_0(message, debug=False, force=True):
def print_rank_0(message, debug=False, force=False):
rank = torch.distributed.get_rank()
if rank == 0 and (debug or force):
print(message)
Expand Down
4 changes: 2 additions & 2 deletions deepspeed/utils/debug.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def printflock(*msgs):
1. Enable the force debug in say partitioning and zero3 files
2. Override the usual versions with ::

def print_rank_0(message, debug=False, force=True):
def print_rank_0(message, debug=False, force=False):
rank = torch.distributed.get_rank()
printflock(f"[{rank}] {message}")
3. run the program and you get both logs non-interleaved
Expand Down Expand Up @@ -99,7 +99,7 @@ def log_rank_file(rank, *msgs):
1. Enable the force debug in say partitioning and zero3 files
2. Override the usual versions of print_rank_0 in those files with ::

def print_rank_0(message, debug=False, force=True):
def print_rank_0(message, debug=False, force=False):
rank = torch.distributed.get_rank()
log_rank_file(rank, message)

Expand Down