Conversation
tjruwase
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
cli99,
conglongli,
eltonzheng,
minjiaz,
niumanar and
samyam
as code owners
tjruwase
removed request for
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
conglongli,
eltonzheng,
minjiaz,
niumanar and
samyam
Collaborator
|
Looks good - thank you for adding it, @tjruwase! Did you want to add why is it off by default - i.e. may fail at times? Or is it just a matter of time before it's always working? |
Contributor
Author
|
We plan to make it work always. I don't see any fundamental reason why it shouldn't, it just needs testing in more scenarios. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document ZeRO-2 offload optimization:
round_robin_gradients.