Skip to content

Improve handling of Init's config arguments #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aphedges wants to merge 1 commit into from
Closed

Improve handling of Init's config arguments #1368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions deepspeed/runtime/zero/partition_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,12 +374,12 @@ def __init__(self,
``"cpu"``. Defaults to ``False``.
config_dict_or_path (dict or ``json file``, optional): If provided, provides configuration.
config (``json file`` or dict, optional): If provided, provides configuration
for swapping fp16 params to NVMe.
for swapping fp16 params to NVMe. Deprecated, use ``config_dict_or_path`` instead.
enabled (bool, optional): If ``False``, this context has no
effect. Defaults to ``True``.
dtype (``dtype``, optional): Can be used to change the data type of the parameters.
Supported options are ``torch.half`` and ``torch.float``. Defaults to ``None``
mpu (``object``, optional): A model parallelism unit object that implements get_{model,data}_parallel_{rank,group,wolrd_size}.
mpu (``object``, optional): A model parallelism unit object that implements get_{model,data}_parallel_{rank,group,world_size}.

This context accelerates model initialization and enables models that
are too large to allocate in their entirety in CPU memory. It has the
Expand Down Expand Up @@ -487,7 +487,6 @@ def get_model():

# Enable fp16 param swapping to NVMe
if self.remote_device == OFFLOAD_NVME_DEVICE:
_ds_config = DeepSpeedConfig(config)
self.param_swapper = AsyncPartitionedParameterSwapper(_ds_config)
else:
self.param_swapper = None
Expand Down