Add torchvision to requirements-dev.txt#1642
Merged
jeffra merged 2 commits intodeepspeedai:masterfrom Dec 16, 2021
Merged
Conversation
aphedges
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
samyam and
tjruwase
as code owners
jeffra
approved these changes
Dec 16, 2021
Collaborator
jeffra
left a comment
jeffra
left a comment
There was a problem hiding this comment.
Good catch, thank you for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torchvisionwas reasonably removed fromrequirements.txtin #1178 because it is not used by the installed version of DeepSpeed. However, it is directly imported intests/, so it should still be in the dev requirements.I discovered this when running
pip install -U --upgrade-strategy eager -e '.[dev]'to update my development environment. I got a pip warning becausetorchvisionwas not updated whiletorchwas. This PR should allow dev installation and updates to now work properly.