Conversation
Unit tests for multi output models
g-karthik
left a comment
g-karthik
left a comment
There was a problem hiding this comment.
Haven't looked at the tests closely -- the core changes look good to me!
|
@tjruwase I think you will need to tell DeepSpeed to update the DeepSpeedExamples submodule in order to incorporate your fix to Squad last night. You can do that from your branch: git submodule update --remote DeepSpeedExamplesThen commit that update. |
|
@tjruwase would you do me a favor and also enable the Megatron tests in your branch for now? Megatron is disabled by default until I get the nightly tests going. Those lines are just commented out in |
Enable Megatron model tests
|
@ShadenSmith Thanks for the guidance. I have updated the DeepSpeedExamples submodule and enabled Megatron in model tests. Now run_sanity_checks passes. For some reason, github has not received notification of the model tests passing. |
* Push to remote * Correctly handle multi output models by doing loss scaling in backward() Unit tests for multi output models * Fix formatting issues * Formatting issues fix * Fix formatting * Update DeepSpeedExamples submodule Enable Megatron model tests
5 participants
Correctly handle multi-output models by performing loss scaling in backward() instead of forward()