Make Ascend NPU available#3831
Merged
tjruwase merged 15 commits intodeepspeedai:masterfrom Jul 22, 2023
Merged
Conversation
hipudding
requested review from
RezaYazdaniAminabadi,
cmikeh2 and
jeffra
as code owners
hipudding
added a commit
to hipudding/DeepSpeed
that referenced
this pull request
Jun 28, 2023
NPU accelerator support is introduced in (deepspeedai#3595). This commit provides two enhancements: 1. Add a new accelerator_name 'npu' for choosing, it can be specified by environment variable or auto detected. 2. Optimize auto detect code in get_accelerator to avoid too many layers of exception throwing.
Contributor
Author
|
@microsoft-github-policy-service agree |
tjruwase
reviewed
Jun 28, 2023
hipudding
added a commit
to hipudding/DeepSpeed
that referenced
this pull request
Jun 29, 2023
When detecting override accelerators there's an error message to show all support accelerators, using an accelerator list instead of hard coding accelerator names in this message. And fix code format issue(yapf).
hipudding
added a commit
to hipudding/DeepSpeed
that referenced
this pull request
Jun 29, 2023
NPU accelerator support is introduced in (deepspeedai#3595). This commit provides two enhancements: 1. Add a new accelerator_name 'npu' for choosing, it can be specified by environment variable or auto detected. 2. Optimize auto detect code in get_accelerator to avoid too many layers of exception throwing.
hipudding
added a commit
to hipudding/DeepSpeed
that referenced
this pull request
Jun 29, 2023
When detecting override accelerators there's an error message to show all support accelerators, using an accelerator list instead of hard coding accelerator names in this message. And fix code format issue(yapf).
hipudding
added a commit
to hipudding/DeepSpeed
that referenced
this pull request
Jun 30, 2023
NPU accelerator support is introduced in (deepspeedai#3595). This commit provides two enhancements: 1. Add a new accelerator_name 'npu' for choosing, it can be specified by environment variable or auto detected. 2. Optimize auto detect code in get_accelerator to avoid too many layers of exception throwing.
hipudding
added a commit
to hipudding/DeepSpeed
that referenced
this pull request
Jun 30, 2023
When detecting override accelerators there's an error message to show all support accelerators, using an accelerator list instead of hard coding accelerator names in this message. And fix code format issue(yapf).
Contributor
Author
|
@tjruwase Good day. Could you please review this PR again and trigger workflows? Thanks. |
Contributor
|
@hipudding, thanks for this PR. We are reviewing currently. Apologies for the delay. |
Contributor
Author
|
:-) Thanks. |
Contributor
Author
BTW, Is this PR still under reviewing? Any review suggestions? Please let me know if there is anything else that needs to be done. |
NPU accelerator support is introduced in (deepspeedai#3595). This commit provides two enhancements: 1. Add a new accelerator_name 'npu' for choosing, it can be specified by environment variable or auto detected. 2. Optimize auto detect code in get_accelerator to avoid too many layers of exception throwing.
When detecting override accelerators there's an error message to show all support accelerators, using an accelerator list instead of hard coding accelerator names in this message. And fix code format issue(yapf).
HCCL is the distribute backend of Ascend NPU, it already implemented in npu plugin for pytorch (https://gitee.com/ascend/pytorch). Add HCCL backend as a not implemented backend to avoid not supported warning.
Ascend NPU does not implement any op yet, leave npu folder empty will throw NoneType[op_name] when not supported op is called. Add this NPUNotImplementedBuilder as the default builder.
Contributor
Author
|
It seems the failing test case is not related to these commits. Please re-trigger this failed workflow, Thanks. |
tjruwase
reviewed
Jul 11, 2023
tjruwase
reviewed
Jul 11, 2023
hipudding
force-pushed
the
npu_support
branch
3 times, most recently
from
7876e3f to
127ecce
Compare
1. cpu and other backend implement their ops in sub dirs under op_builder, cuda_accelerator should skip these sub dirs. 2. Each backend will have its own NotImplementedBuilder, add device prefix to this class to distinguish.
delock
reviewed
Jul 14, 2023
hipudding
force-pushed
the
npu_support
branch
4 times, most recently
from
6b48a6a to
eb8ab12
Compare
tjruwase
approved these changes
Jul 19, 2023
Contributor
Author
|
Good day. This PR is approved and ready to merge. But one workflow is failed due to OOM(not related to these changes). Could you retrigger this workflow and merge this PR? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NPU accelerator support is introduced in (#3595).
This commit provides two enhancements: