Skip to content

Fix multinode runner to properly append to PDSH_SSH_ARGS_APPEND #4373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loadams merged 1 commit into from
Sep 20, 2023
Merged

Fix multinode runner to properly append to PDSH_SSH_ARGS_APPEND #4373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepspeed/launcher/multinode_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def parse_user_args(self):
def get_cmd(self, environment, active_resources):
environment['PDSH_RCMD_TYPE'] = 'ssh'
if self.args.ssh_port is not None: # only specify ssh port if it is specified
environment["PDSH_SSH_ARGS_APPEND"] = f" -p {self.args.ssh_port}"
environment["PDSH_SSH_ARGS_APPEND"] += f" -p {self.args.ssh_port}"

active_workers = ",".join(active_resources.keys())
logger.info("Running on the following workers: %s" % active_workers)
Expand Down