Skip to content

Revert "Don't check overflow for bf16 data type (#4512)" #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
loadams wants to merge 2 commits into from
Closed

Revert "Don't check overflow for bf16 data type (#4512)" #4591

loadams wants to merge 2 commits into from

Conversation

@loadams
Copy link
Collaborator

@loadams loadams commented Oct 31, 2023

This reverts commit 244040c.

@loadams
Copy link
Collaborator Author

loadams commented Oct 31, 2023

This commit was not the root cause of the problem, just happened to pass the PR checks despite it failing them on its own too.

@loadams loadams closed this Oct 31, 2023
@RUAN-ZX RUAN-ZX mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffra jeffra Awaiting requested review from jeffra

@tjruwase tjruwase Awaiting requested review from tjruwase tjruwase is a code owner

@mrwyattii mrwyattii Awaiting requested review from mrwyattii

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loadams