Skip to content

Release overlap_comm & contiguous_gradients restrictions for ZeRO 1 #4887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjruwase merged 2 commits into from
Jan 5, 2024
Merged

Release overlap_comm & contiguous_gradients restrictions for ZeRO 1 #4887

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ec2151
Release overlap_comm & contiguous_gradients restrictions for ZeRO 1
li-plus Dec 30, 2023
1d9c381
Merge branch 'master' into opt-zero1
tjruwase Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions deepspeed/runtime/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,13 +1486,6 @@ def _configure_zero_optimizer(self, optimizer):
assert not isinstance(optimizer, DummyOptim), "zero stage {} requires an optimizer".format(zero_stage)

log_dist(f'Creating {model_dtype} ZeRO stage {zero_stage} optimizer', ranks=[0])
# Overlap and contiguous grads are meaningless in stage 1 and are ignored
if zero_stage == ZeroStageEnum.optimizer_states:
overlap_comm = False
round_robin_gradients = False
# Non-MoE requires contiguous grads to be disabled w. stage 1
if not self.has_moe_layers:
contiguous_gradients = False

if isinstance(self.module, PipelineModule):
if overlap_comm:
Expand Down