Use ninja to speed up build #5088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinzhen-lin
requested review from
arashb,
awan-10 and
mrwyattii
as code owners
loadams
reviewed
Feb 6, 2024
Contributor
Author
|
Accidentally closed PR, reopen it. |
mrwyattii
approved these changes
Feb 12, 2024
Contributor
mrwyattii
left a comment
mrwyattii
left a comment
There was a problem hiding this comment.
Thanks @jinzhen-lin this is a great improvement in compile time for all the ops (~18 min --> ~10 min)!
tjruwase
reviewed
Feb 14, 2024
tjruwase
reviewed
Feb 14, 2024
tjruwase
reviewed
Feb 19, 2024
Contributor
|
@jinzhen-lin, thanks for improving the PR. Can you please resolve the formatting issues? |
Contributor
Author
Done. |
Contributor
Thanks! Please note that we are investigating the following CI failure, which is unrelated to your PR. |
mrwyattii
approved these changes
Feb 20, 2024
Collaborator
This should be resolved now. Thanks @jinzhen-lin - this speeds up our nv-pre-compile-ops builds by roughly 2x. |
loadams
approved these changes
Feb 20, 2024
This was referenced Feb 26, 2024
ShellyNR
pushed a commit
to ShellyNR/DeepSpeed
that referenced
this pull request
Mar 11, 2024
Deepspeed have too many ops now, and it take too many time to pre-build all ops. I notice deepspeed disabled `ninja` 4 years ago (deepspeedai#298) and I think we should consider enable it now. The issue mentioned in deepspeedai#298 can be solved by resolving `include_dirs` to absolute path. --------- Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com> Co-authored-by: Logan Adams <loadams@microsoft.com> Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com> Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com>
ShellyNR
pushed a commit
to ShellyNR/DeepSpeed
that referenced
this pull request
Mar 11, 2024
deepspeedai#5192 reports an issue with the latest DeepSpeed release (0.13.3) related to pre-compilation and the recently re-enabled `ninja` support in deepspeedai#5088. Reverting to disabling `ninja` by default, but users can still enable it with `DS_ENABLE_NINJA=1` until we can further debug to understand the problem.
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
Deepspeed have too many ops now, and it take too many time to pre-build all ops. I notice deepspeed disabled `ninja` 4 years ago (deepspeedai#298) and I think we should consider enable it now. The issue mentioned in deepspeedai#298 can be solved by resolving `include_dirs` to absolute path. --------- Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com> Co-authored-by: Logan Adams <loadams@microsoft.com> Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com> Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com>
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
deepspeedai#5192 reports an issue with the latest DeepSpeed release (0.13.3) related to pre-compilation and the recently re-enabled `ninja` support in deepspeedai#5088. Reverting to disabling `ninja` by default, but users can still enable it with `DS_ENABLE_NINJA=1` until we can further debug to understand the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deepspeed have too many ops now, and it take too many time to pre-build all ops.
I notice deepspeed disabled
ninja4 years ago (#298) and I think we should consider enable it now.The issue mentioned in #298 can be solved by resolving
include_dirsto absolute path.