Skip to content

Avoid graph break by removing redundant requires_grad attr change #7158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2025
Merged

Avoid graph break by removing redundant requires_grad attr change #7158

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a2503a2
Avoid graph break by removing redundant requires_grad attr change
deepcharm Mar 20, 2025
052ef85
Small fix
deepcharm Mar 20, 2025
cf18d95
Revert "Small fix"
deepcharm Mar 20, 2025
0919cb2
Merge branch 'master' into master
loadams Mar 20, 2025
475be04
Merge branch 'master' into master
hwchen2017 Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion deepspeed/runtime/zero/partition_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1899,7 +1899,6 @@ def _allgather_params(self, param_list, hierarchy=0):

tensor_size = partition_size * self.num_partitions
flat_tensor = torch.empty(tensor_size, dtype=param_list[0].ds_tensor.dtype, device=self.local_device)
flat_tensor.requires_grad = False
partitions = []
for i in range(self.num_partitions):
start = partition_size * i
Expand Down