Skip to content

Local rank -1 fix #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffra merged 2 commits into from
Feb 1, 2021
Merged

Local rank -1 fix #720

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bed777
local rank of -1 means not set
jeffra Feb 1, 2021
18a6229
Merge branch 'master' into jeffra/mpi-rank-fix
jeffra Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepspeed/runtime/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ def _do_args_sanity_check(self, args):
local_rank_err = "DeepSpeed requires a command line parameter of --local_rank [int] and/or setting the LOCAL_RANK environment variable."
if hasattr(args, 'local_rank'):
assert type(args.local_rank) == int, local_rank_err
if "LOCAL_RANK" in os.environ:
if "LOCAL_RANK" in os.environ and args.local_rank >= 0:
env_local_rank = int(os.environ.get("LOCAL_RANK", -1))
assert env_local_rank == args.local_rank, \
f"Mismatch in local rank setting, args.local_rank={args.local_rank} but env['LOCAL_RANK']={env_local_rank}."
Expand Down