-
Notifications
You must be signed in to change notification settings - Fork 4.6k
rollback #6726 #7258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rollback #6726 #7258
Conversation
|
Didn't remove the test from this PR yet because I want to witness the test failure without this change. |
ba78b08 to
d628bb2
Compare
Signed-off-by: Guokai Ma <guokai.ma@gmail.com>
|
@delock - I don't have permissions to "run tests" on this PR, do you have that button available to you? |
nv-torch-latest-v100 failed, seems this workflow has problem, latest success state is 3 days ago. |
|
Could you please include this fix in version ds 0.16.8? |
@hijkzzz - yes, as we fix the CI issues and merge this PR we can release this in a DeepSpeed release. |
|
What is the status on this PR? I would really like to use the new DeepSpeed versions, but I'm stuck at v0.15.x until this PR is merged |
@casper-hansen, this PR will merge once CI completes. Should be available in release next week. @loadams, FYI |
@sfc-gh-truwase agreed, @casper-hansen - sorry for the delay on this. We need to fix the CI and will get a release out with this as soon as we can. |
This PR rollback deepspeedai#6726 which caused deepspeedai#7116 . --------- Signed-off-by: Guokai Ma <guokai.ma@gmail.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com> Co-authored-by: Olatunji Ruwase <tunji.ruwase@snowflake.com> Signed-off-by: yisheng <yi.sheng@intel.com>
This PR rollback deepspeedai#6726 which caused deepspeedai#7116 . --------- Signed-off-by: Guokai Ma <guokai.ma@gmail.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com> Co-authored-by: Olatunji Ruwase <tunji.ruwase@snowflake.com> Signed-off-by: Max Kovalenko <mkovalenko@habana.ai>
This PR rollback deepspeedai#6726 which caused deepspeedai#7116 . --------- Signed-off-by: Guokai Ma <guokai.ma@gmail.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com> Co-authored-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
This PR rollback #6726 which caused #7116 .