Skip to content

Conversation

@delock
Copy link
Collaborator

@delock delock commented Apr 28, 2025

This PR rollback #6726 which caused #7116 .

@delock delock requested review from tjruwase and tohtana as code owners April 28, 2025 13:16
@delock
Copy link
Collaborator Author

delock commented Apr 28, 2025

Didn't remove the test from this PR yet because I want to witness the test failure without this change.

Signed-off-by: Guokai Ma <guokai.ma@gmail.com>
Signed-off-by: Guokai Ma <guokai.ma@gmail.com>
@delock delock requested a review from loadams as a code owner April 28, 2025 14:48
@loadams
Copy link
Collaborator

loadams commented Apr 28, 2025

@delock - I don't have permissions to "run tests" on this PR, do you have that button available to you?

@delock
Copy link
Collaborator Author

delock commented Apr 29, 2025

@delock - I don't have permissions to "run tests" on this PR, do you have that button available to you?

nv-torch-latest-v100 failed, seems this workflow has problem, latest success state is 3 days ago.

@loadams
Copy link
Collaborator

loadams commented Apr 30, 2025

@delock - I don't have permissions to "run tests" on this PR, do you have that button available to you?

nv-torch-latest-v100 failed, seems this workflow has problem, latest success state is 3 days ago.

@delock, yes we are getting that fixed shortly.

@hijkzzz
Copy link

hijkzzz commented May 6, 2025

Could you please include this fix in version ds 0.16.8?

@loadams
Copy link
Collaborator

loadams commented May 7, 2025

Could you please include this fix in version ds 0.16.8?

@hijkzzz - yes, as we fix the CI issues and merge this PR we can release this in a DeepSpeed release.

@casper-hansen
Copy link

What is the status on this PR? I would really like to use the new DeepSpeed versions, but I'm stuck at v0.15.x until this PR is merged

@sfc-gh-truwase
Copy link
Collaborator

What is the status on this PR? I would really like to use the new DeepSpeed versions, but I'm stuck at v0.15.x until this PR is merged

@casper-hansen, this PR will merge once CI completes. Should be available in release next week.

@loadams, FYI

@loadams
Copy link
Collaborator

loadams commented May 16, 2025

What is the status on this PR? I would really like to use the new DeepSpeed versions, but I'm stuck at v0.15.x until this PR is merged

@casper-hansen, this PR will merge once CI completes. Should be available in release next week.

@loadams, FYI

@sfc-gh-truwase agreed, @casper-hansen - sorry for the delay on this. We need to fix the CI and will get a release out with this as soon as we can.

@loadams loadams enabled auto-merge May 19, 2025 03:26
@loadams loadams added this pull request to the merge queue May 19, 2025
Merged via the queue into master with commit f459502 May 19, 2025
12 checks passed
@loadams loadams deleted the gma/rollback_6726 branch May 19, 2025 06:04
ys950902 pushed a commit to ys950902/DeepSpeed that referenced this pull request May 21, 2025
This PR rollback deepspeedai#6726 which caused
deepspeedai#7116 .

---------

Signed-off-by: Guokai Ma <guokai.ma@gmail.com>
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Co-authored-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
Signed-off-by: yisheng <yi.sheng@intel.com>
deepcharm pushed a commit to deepcharm/DeepSpeed that referenced this pull request Jun 16, 2025
This PR rollback deepspeedai#6726 which caused
deepspeedai#7116 .

---------

Signed-off-by: Guokai Ma <guokai.ma@gmail.com>
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Co-authored-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
Signed-off-by: Max Kovalenko <mkovalenko@habana.ai>
mauryaavinash95 pushed a commit to DataStates/DeepSpeed that referenced this pull request Oct 4, 2025
This PR rollback deepspeedai#6726 which caused
deepspeedai#7116 .

---------

Signed-off-by: Guokai Ma <guokai.ma@gmail.com>
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Co-authored-by: Olatunji Ruwase <tunji.ruwase@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants