Update Llama check to use module instead of model #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekurile
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashb,
awan-10,
conglongli,
duli2012,
eltonzheng,
jeffra,
minjiaz,
mrwyattii,
samyam,
tjruwase,
xiaoxiawu-microsoft and
yaozhewei
as code owners
awan-10
approved these changes
Sep 14, 2023
LeetJoe
pushed a commit
to LeetJoe/DeepSpeedExamples
that referenced
this pull request
Sep 15, 2023
This PR updates the Llama check in the DS-Chat Step 3 PPO trainer to use the actor module object instead of model when accessing the configuration. This is necessary since not all model types will work when using model, particularly for the BLOOM model family.
hwchen2017
pushed a commit
that referenced
this pull request
Jun 8, 2025
This PR updates the Llama check in the DS-Chat Step 3 PPO trainer to use the actor module object instead of model when accessing the configuration. This is necessary since not all model types will work when using model, particularly for the BLOOM model family.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Llama check in the DS-Chat Step 3 PPO trainer to use the actor
moduleobject instead ofmodelwhen accessing the configuration. This is necessary since not all model types will work when usingmodel, particularly for the BLOOM model family.