Conversation
tjruwase
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashb,
conglongli,
duli2012,
eltonzheng,
jeffra,
mrwyattii,
samyam,
xiaoxiawu-microsoft and
yaozhewei
as code owners
tjruwase
removed request for
RezaYazdaniAminabadi,
ShadenSmith,
arashb,
conglongli,
duli2012,
eltonzheng,
jeffra,
mrwyattii,
samyam,
xiaoxiawu-microsoft and
yaozhewei
minjiaz
reviewed
Sep 24, 2023
Contributor
minjiaz
left a comment
minjiaz
left a comment
There was a problem hiding this comment.
Overall LGTM. Added some minor suggestions to keep the main generation function cleaner.
hwchen2017
pushed a commit
that referenced
this pull request
Jun 8, 2025
* FlexGen reference * Fix DS version and opt issue * Fix script * Fix type and padding * loop option * PR feedback * Bug fix * Format fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix padding, dtype, and version issues