Skip to content

deepspeed-chat: train v_head when only optimizing lora #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjruwase merged 2 commits into from
Oct 16, 2023
Merged

deepspeed-chat: train v_head when only optimizing lora #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
679e800
deepspeed-chat: train v_head when only optimizing lora
Sep 12, 2023
761366d
Merge branch 'master' into 8_train_v_head_lora
lekurile Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion applications/DeepSpeed-Chat/training/step2_reward_model_finetuning/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,8 @@ def main():
args.lora_module_name,
args.lora_dim)
if args.only_optimize_lora:
rm_model = only_optimize_lora_parameters(rm_model)
rm_model = only_optimize_lora_parameters(
rm_model, force_optimize_params=['v_head.weight'])
rm_model = make_model_gradient_checkpointing_compatible(rm_model)

train_phase = 2
Expand Down
4 changes: 2 additions & 2 deletions applications/DeepSpeed-Chat/training/utils/module/lora.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,10 @@ def convert_lora_to_linear_layer(model):
return model


def only_optimize_lora_parameters(model):
def only_optimize_lora_parameters(model, force_optimize_params=[]):
# turn off the gradient of all the parameters except the LoRA parameters
for name, param in model.named_parameters():
if "lora_right_weight" in name or "lora_left_weight" in name:
if "lora_right_weight" in name or "lora_left_weight" in name or name in force_optimize_params:
param.requires_grad = True
else:
param.requires_grad = False
Expand Down