Resolves the issue with evaluation on step2 for single GPU #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PareesaMS
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashb,
awan-10,
conglongli,
duli2012,
eltonzheng,
jeffra,
minjiaz,
mrwyattii,
samyam,
tjruwase,
xiaoxiawu-microsoft and
yaozhewei
as code owners
PareesaMS
removed request for
RezaYazdaniAminabadi,
ShadenSmith,
minjiaz and
xiaoxiawu-microsoft
mrwyattii
suggested changes
Oct 11, 2023
applications/DeepSpeed-Chat/training/utils/model/model_utils.py
Outdated
Show resolved
Hide resolved
mrwyattii
approved these changes
Oct 12, 2023
mrwyattii
approved these changes
Oct 12, 2023
hwchen2017
pushed a commit
that referenced
this pull request
Jun 8, 2025
Co-authored-by: Michael Wyatt <mrwyattii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For single GPU run, torch.distributed is not defined. This PR fixes this issue so the evaluation script for step2 runs successfully on single GPU