Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #75 reduce the bundle by ignoring the TCP connection class in bro… #117

Merged
merged 3 commits into from
May 24, 2016

Conversation

yasserf
Copy link
Contributor

@yasserf yasserf commented May 17, 2016

…wserify

@WolframHempel
Copy link
Member

Nice - can we make sure it still works with webpack?

@yasserf
Copy link
Contributor Author

yasserf commented May 17, 2016

Is webpack affected by the browserify config in grunt?

@WolframHempel
Copy link
Member

It's reading this bit from package.json

 "browser": {
    "net": false
  },

@coveralls
Copy link

Coverage Status

Coverage decreased (-69.3%) to 27.29% when pulling e2685e1 on enhancement/#74-reduce-client-size into 388e173 on master.

@yasserf yasserf force-pushed the enhancement/#74-reduce-client-size branch from e2685e1 to f3bbcb2 Compare May 24, 2016 16:46
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.773% when pulling f3bbcb2 on enhancement/#74-reduce-client-size into 1341c1d on master.

@yasserf yasserf merged commit 9f44ec7 into master May 24, 2016
@yasserf yasserf deleted the enhancement/#74-reduce-client-size branch May 24, 2016 16:50
@yasserf yasserf removed the in review label May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants