Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bamPEFragmentSize max fragment size shown on plot #337

Closed
samuelCollombet opened this issue Apr 15, 2016 · 5 comments
Closed

bamPEFragmentSize max fragment size shown on plot #337

samuelCollombet opened this issue Apr 15, 2016 · 5 comments
Assignees
Milestone

Comments

@samuelCollombet
Copy link

samuelCollombet commented Apr 15, 2016

Would be nice to have the option to change the max value on the x axis.
I am using it to visualized the fragment distribution of ATACseq data, and 2 x mean of fragment size is not enough. I personally change the parameter in the .py file ([mean] x 2 changed for [max]), but it would be ncie to be able to change the parameter on the fly.

@dpryan79
Copy link
Collaborator

Indeed, this probably works poorly for ATACseq. Should be an easy enough change. Were you thinking of having some sort of max length parameter or instead one to just change the 2 to some user-specified value? Either would be possible and we can do whichever is preferred.

@dpryan79 dpryan79 added this to the 2.3 milestone Apr 15, 2016
@dpryan79 dpryan79 self-assigned this Apr 15, 2016
@samuelCollombet
Copy link
Author

In my case I prefer to use the max, so I know what value it is, but it might depends on the user preference.
Also Just realized, havign the possibiltiy ot have the frequency in log scale would be nice :)

@dpryan79
Copy link
Collaborator

OK, user-specified max value and a log scale option. Those are quick and easy.

@samuelCollombet
Copy link
Author

Cool! Thanks a lot!

@dpryan79
Copy link
Collaborator

I just added this to develop both via the CLI and Galaxy. There's now a --maxFragmentLength parameter to set the X axis maximum and a --logScale option that toggles plotting log frequencies. This are both great ideas, thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants