Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Median read length inference with no sequence present #369

Closed
dpryan79 opened this issue May 31, 2016 · 1 comment
Closed

Median read length inference with no sequence present #369

dpryan79 opened this issue May 31, 2016 · 1 comment
Assignees
@dpryan79
Labels
bug
Milestone
2.3

Comments

@dpryan79
Copy link
Collaborator

For paired-end reads, we use infer_query_length(), since sometimes people strip the sequence out of BAM files. Apparently we never made that change for SE reads, so it's possible to get division by zero errors if someone tries to normalize to 1x (due to using 0 as the median read length).

This is essentially a little reminder to me to make this fix in develop tomorrow.
@dpryan79 dpryan79 added the bug label May 31, 2016
@dpryan79 dpryan79 added this to the 2.3 milestone May 31, 2016
@dpryan79 dpryan79 self-assigned this May 31, 2016
dpryan79 added a commit that referenced this issue Jun 1, 2016
@dpryan79
Fix #369, switch all read.query_length instances to read.infer_query_…
8875c0f 
…length(always=False)
@dpryan79
Copy link
Collaborator Author

dpryan79 commented Jun 1, 2016

This is now fixed in develop

@dpryan79 dpryan79 closed this as completed Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpryan79 dpryan79

Labels
bug
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
1 participant
@dpryan79